Skip to content

feat: zod version checker#495

Closed
neo773 wants to merge 1 commit into
triggerdotdev:mainfrom
neo773:zod-fix
Closed

feat: zod version checker#495
neo773 wants to merge 1 commit into
triggerdotdev:mainfrom
neo773:zod-fix

Conversation

@neo773

@neo773 neo773 commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works
trigger.mp4

/closes #436
/claim #436

@changeset-bot

changeset-bot Bot commented Sep 21, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3476c3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

matt-aitken
matt-aitken reviewed Sep 21, 2023
View reviewed changes
Comment thread packages/cli/src/commands/dev.ts
import chalk from "chalk";
import path from 'path';
import { createRequire } from 'node:module';
import { PackageFile } from "npm-check-updates/build/src/types/PackageFile";

@matt-aitken matt-aitken Sep 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not exported from the main index file? When you build the package I think this will fail

@neo773 neo773 Sep 21, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-aitken
Built fine, since it's a type only import

image

@ericallam

ericallam commented Sep 22, 2023

Copy link
Copy Markdown
Member

Thanks for this 🙏 but it's no longer necessary to check for the Zod version because of #500, so closing this 👍

@ericallam ericallam closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-aitken matt-aitken matt-aitken left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@neo773 @ericallam @matt-aitken